-
Notifications
You must be signed in to change notification settings - Fork 10
Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: angular19
Are you sure you want to change the base?
Conversation
|
|
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
|
@copilot rebase or make any smal change, so the github actions pr pipeline is getting triggered |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Added a clarifying comment to trigger the CI pipeline. Commit: 04dd2f4 |
…s components Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…n strategy Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…nents Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…alogs Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…r modal dropdowns Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…odals Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…ositioning Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…o solution Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Angular 21 upgrade broke component initialization, unit tests, and modal dropdowns due to stricter lifecycle rules and new dialog top-layer implementation.
Changes
Component Lifecycle
ChangeDetectorRef.markForCheck()after async data updates inngOnInit()chainsEformsPageComponent,FullLayoutComponent,FooterComponent,EntityEditCreateComponent,NavigationComponent,HeaderComponent,FoldersComponent,EntitySearchComponent,EntitySelectComponentdetectChanges()in init phase blocks subsequent async operationsUnit Test Compatibility
getParsedResult(),getCurrentLang(), event emittersonLangChange,onTranslationChange,onDefaultLangChange(required by Angular 21's TranslatePipe)Property Binding Syntax
dropdownPositionfrom string attribute to property binding:[dropdownPosition]="'bottom'"Modal Dropdown Positioning (Partial)
[appendTo]="'.cdk-overlay-pane'"to mtx-select components in modalsKnown Limitation
mtx-select dropdowns in modals remain imperfectly positioned. Angular 21's native top-layer (via
popover="manual") creates new stacking context incompatible with current mtx-select overlay implementation. TheappendToworkaround keeps dropdowns visible but positioning relative to input fields is incorrect.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.