feat(planning): standard text size in history modal, open to all users#1650
Merged
Conversation
Remove the extra-small font sizes from the Aktivitetslog timeline — text now inherits the dialog's standard size via the --mat-dialog-supporting-text-size token (verified 14px, equal to the dialog body text). Widen the time column to max-content accordingly. Remove the admin-only gate on the history button; the endpoint was never admin-restricted server-side. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the Time Planning “Aktivitetslog” (version history) UI to use standard dialog text sizing and makes the history action available to all users (not just admins).
Changes:
- Removed admin-only gating for opening the version history modal in the Workday dialog.
- Standardized typography in the version history modal by relying on the dialog’s supporting-text token (and adjusted a few specific elements).
- Tweaked the history timeline layout to prevent time values from wrapping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/workday-entity/workday-entity-dialog.component.ts | Removes the admin selector usage tied to the history button gating. |
| eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/workday-entity/workday-entity-dialog.component.html | Makes the history button visible for all users by removing *ngIf on admin. |
| eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/version-history-modal/version-history-modal.component.scss | Standardizes modal text sizing via a Material token override and adjusts timeline grid column sizing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
9
| <button | ||
| *ngIf="selectAuthIsAdmin$ | async" | ||
|
|
||
| mat-icon-button | ||
| (click)="openVersionHistory()" | ||
| matTooltip="{{'View history' | translate}}"> |
Comment on lines
67
to
70
| .history-event { | ||
| display: grid; | ||
| grid-template-columns: 3.35rem minmax(0, 1fr); | ||
| grid-template-columns: max-content minmax(0, 1fr); | ||
| gap: 6px 12px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mat-dialog-supporting-text-sizetoken (verified live at 14px, equal to the workday dialog's own body text). The time column widened tomax-contentto fit.*ngIf(plus its now-dead selector).Verification
Verified live in the browser: computed font-size 14px on every timeline element (action/time/actor/hint/day-heading/intro), matching the dialog body text; time column fits HH:mm without wrapping; the token override is scoped to this dialog's host and cannot leak to other dialogs.
🤖 Generated with Claude Code