Skip to content

fixes to ipset_sync#2

Open
rayarachelian wants to merge 3 commits intomighq:masterfrom
rayarachelian:master
Open

fixes to ipset_sync#2
rayarachelian wants to merge 3 commits intomighq:masterfrom
rayarachelian:master

Conversation

@rayarachelian
Copy link
Copy Markdown

Fixes to ipset_sync to:

  • ignore blank lines
  • ignore comments both single line and at the end of a line
  • ignore duplicate IPs
  • ignore extra create line.

Also added a trivial spec for unit tests - note this only applies to RH6 and similar, will need changes for RH7, etc.

@mighq

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, case's in puppet against strings are case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants