Conversation
This commit addresses issues with compressed backup data and adds new functionality for detailed backup information: Download improvements: - Fix gzip detection to check file magic bytes (0x1f 0x8b) in addition to Content-Encoding header. Object storage signed URLs often serve .gz files without the Content-Encoding header, causing decompressed content to be displayed as binary gibberish - Add comprehensive debug logging to download functions for easier troubleshooting - Use buffered reader with Peek() to detect gzip format without consuming the stream Describe command enhancements: - Add --details flag to fetch additional backup information including volume snapshots, resource lists, backup results, and item operations - Exclude describe command from output wrapper (similar to logs command) to prevent buffering issues with large downloads - Update tests to reflect describe command exclusion Installation improvements: - Enhance make install output formatting with clearer status messages - Show version info during installation verification Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>
Extract common download request creation and polling logic into a new shared function CreateAndWaitForDownloadURL. This eliminates ~53 lines of duplicated code between the logs and describe commands. Key changes: - Add CreateAndWaitForDownloadURL function to handle request creation and polling with optional progress callbacks - Add OnProgress callback to DownloadRequestOptions for progress indication - Refactor logs command to use shared function (75 lines → 22 lines) - Simplify printDetailedBackupInfo to accept backup name string instead of full NonAdminBackup object - Remove debug log statements from download.go - Clean up unused imports in logs.go This maintains the key behavioral difference between commands: - logs: streams content for low memory usage - describe --details: buffers content for formatting Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>
Align nonadmin backup describe output with admin backup format: - Move Resource List before Backup Volumes section to match admin order - Parse and format Resource List JSON as hierarchical structure with bullets - Skip printing sections with no data (empty snapshots, no errors/warnings) - Parse and format Volume Snapshot Details, Backup Results, and Item Operations as readable JSON - Split Backup Results into separate Errors and Warnings subsections Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>
This was
linked to
issues
Feb 4, 2026
Remove unused assignment to hasOutput variable in printDetailedBackupInfo function. The assignment at line 447 had no effect since it was in the last section and the variable was never used afterward. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the changes were made
This PR improves the nonadmin backup describe command with better output formatting, bug fixes, and code quality improvements:
1. Improve nonadmin backup describe output formatting
2. Refactor download request logic to eliminate code duplication
ProcessDownloadRequestfunction in the shared package3. Fix gzip decompression for backup downloads and enhance describe command
How to test the changes made
Prerequisites