Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ jobs:
build:
name: Build
runs-on: macos-latest
permissions:
contents: read
security-events: write
steps:
- name: Checkout
uses: actions/checkout@v6
Comment on lines +65 to 70
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions is set at the job level but only grants security-events: write. In GitHub Actions, specifying permissions overrides defaults, so contents: read is no longer granted and actions/checkout (and other steps that read the repo) can fail with a 403. Add contents: read (and any other required scopes) alongside security-events: write.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -104,6 +107,7 @@ jobs:
detailed_summary: true

- name: Archive Test Report
if: always()
uses: actions/upload-artifact@v7
with:
name: "Test-Artifacts"
Expand All @@ -114,23 +118,24 @@ jobs:
run: ./gradlew apiCheck

- name: Run Lint
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request'
run: ./gradlew lintDebug

- name: Setup Ruby
if: github.event_name == 'pull_request'
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.0'
bundler-cache: true

- name: Run Danger
if: github.event_name == 'pull_request'
- name: Collect Lint SARIF reports
if: github.event_name == 'pull_request'
run: |
gem install danger
bundle exec danger --dangerfile=Dangerfile --danger_id=danger-pr
env:
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
mkdir -p sarif-reports
find . -name "lint-results-debug.sarif" | while read f; do
module=$(echo "$f" | sed 's|^\./||' | sed 's|/build/reports/.*||' | sed 's|/|-|g')
cp "$f" "sarif-reports/${module}-lint.sarif"
done

- name: Upload Lint SARIF
if: always() && github.event_name == 'pull_request'
uses: github/codeql-action/upload-sarif@v4
with:
sarif_file: 'sarif-reports'
category: android-lint
Comment thread
mikepenz marked this conversation as resolved.

- name: Prepare Keystore and Local.
if: startsWith(github.ref, 'refs/tags/')
Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: PR Checks

on:
pull_request:

permissions:
pull-requests: read

jobs:
quality-gates:
name: Quality Gates
runs-on: ubuntu-latest
steps:
- name: PR Quality Gates
uses: actions/github-script@v8
with:
script: |
const { data: pr } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number
});
Comment thread
mikepenz marked this conversation as resolved.
const labels = pr.labels.map(l => l.name);
if (labels.some(l => l.includes('DO NOT MERGE')))
core.setFailed('PR specifies label DO NOT MERGE');
if (labels.some(l => l.includes('Engineers at work')) || pr.title.includes('[WIP]'))
core.warning('PR is marked as Work in Progress');
if (pr.additions + pr.deletions > 5000)
core.warning('Big PR');
38 changes: 0 additions & 38 deletions Dangerfile

This file was deleted.

8 changes: 0 additions & 8 deletions Gemfile

This file was deleted.

78 changes: 0 additions & 78 deletions Gemfile.lock

This file was deleted.

2 changes: 1 addition & 1 deletion settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependencyResolutionManagement {

versionCatalogs {
create("baseLibs") {
from("com.mikepenz:version-catalog:0.14.1")
from("com.mikepenz:version-catalog:0.14.2")
}
}
}
Expand Down
Loading