Fix sign error in getSunrise / getSunset methods#51
Open
guillerodriguez wants to merge 1 commit intomikereedell:masterfrom
Open
Fix sign error in getSunrise / getSunset methods#51guillerodriguez wants to merge 1 commit intomikereedell:masterfrom
guillerodriguez wants to merge 1 commit intomikereedell:masterfrom
Conversation
SunriseSunsetCalculator.getSunrise(...) accepts a "degrees below
the horizon" parameter, which corresponds to a solar zenith angle
of 90 + X degrees.
However, the implementation used the opposite sign to construct
the Zenith instance, so a caller would get the time at which the
sun reaches X degrees *above* the horizon, not below. The same
problem is also present in the getSunset(...) method.
Fix both by flipping the sign:
new Zenith(90 - degrees) -> new Zenith(90 + degrees)
Fixes: mikereedell#50
guillerodriguez
force-pushed
the
fix/getsunrise-getsunset-zenith-sign
branch
from
f289005 to
8b8a55a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SunriseSunsetCalculator.getSunrise(...) accepts a "degrees below the horizon" parameter, which corresponds to a solar zenith angle of 90 + X degrees.
However, the implementation used the opposite sign to construct the Zenith instance, so a caller would get the time at which the sun reaches X degrees above the horizon, not below. The same problem is also present in the getSunset(...) method.
Fix both by flipping the sign:
Fixes: #50