Add support for relative '../' paths and ignore commented !includes#2
Open
Jbelmonte wants to merge 2 commits intomikestowe:masterfrom
Open
Add support for relative '../' paths and ignore commented !includes#2Jbelmonte wants to merge 2 commits intomikestowe:masterfrom
Jbelmonte wants to merge 2 commits intomikestowe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
First of all, thank you for your merge solution! I needed that to import RAML into Postman.
Secondly I must say I am not a PHP developer, so please forgive any bad use of PHP.
This pull request contains the following changes/improvements:
Bellow you'll find an example.
#)!includelines. Includes were processed anyway, causing syntax errors as the first line remained commented.!includein all available situations:traits,securitySchemes,resourceTypesand so on.\non each line.File structure
Cross references
The problem
$ php ramlMerge.php api.raml [...] # Unable to Include ~/api/../yaml-core/traits/trait.localizable.yaml [...]The folder containing referenced file
../yaml-core/traits/trait.localizable.yamlhad to be computed based on current file being included (/yaml/traits.yaml).Of course, that complex specification was valid according to RAML parsers used by RAML designer and RAML console.