Add URL scheme support for automation and external integration#286
Merged
mikker merged 3 commits intomikker:mainfrom Nov 26, 2025
Merged
Add URL scheme support for automation and external integration#286mikker merged 3 commits intomikker:mainfrom
mikker merged 3 commits intomikker:mainfrom
Conversation
Implements leaderkey:// URL handlers for: - Configuration management (config-reload, config-reveal) - Window control (activate, hide, reset) - Navigation with execute parameter - Settings and about dialogs
Owner
|
Great additions 👍 |
Contributor
Author
Added tests. |
Owner
|
This is not testing functionality, it's duplicating code and then testing the duplicate. If anything, this will just give us a false sense of security. A better pattern might be to extract the parsing to a simple class that returns and action enum. That's very testable - pass the url, return an enum case - and extracts and encapsulates the logic from the delegate as well. Makes sense? |
Contributor
Author
|
what about this version? |
Owner
|
Yes, much better 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements leaderkey:// URL handlers for: