Add app-specific shortcuts with optional when filters#311
Draft
rahulxsomething wants to merge 1 commit intomikker:mainfrom
Draft
Add app-specific shortcuts with optional when filters#311rahulxsomething wants to merge 1 commit intomikker:mainfrom
when filters#311rahulxsomething wants to merge 1 commit intomikker:mainfrom
Conversation
Allow actions and groups to target specific apps via a `when` field containing `includeApps` and/or `excludeApps` bundle ID arrays. The same key can now map differently depending on the frontmost app, while configs without `when` fields behave identically to before. Resolution uses a three-tier precedence system: - Tier A: includeApps matches frontmost app (most specific) - Tier B: excludeApps non-empty, includeApps empty (everywhere-except) - Tier C: no when / both empty (global fallback) Includes tier-aware config validation and 28 new unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whenfield to actions and groups withincludeApps/excludeAppsbundle ID arrayst→ Terminal globally,t→ Google in Chrome)excludeAppswhenfields behave identically to before (fully backward compatible)Config example
{ "key": "a", "type": "command", "value": "chrome-action", "when": { "includeApps": ["com.google.Chrome"], "excludeApps": ["com.google.Chrome.canary"] } }Precedence tiers
includeAppsmatches frontmost appexcludeAppsnon-empty,includeAppsemptywhen/ both arrays emptyChanges
Leader Key/UserConfig.swiftWhenstruct;whenon Action, Group, ActionOrGroup, ItemLeader Key/AppFilter.swiftLeader Key/Controller.swiftshow(), resolve inhandleKey()Leader Key/UserState.swiftfrontmostBundleIDpropertyLeader Key/Cheatsheet.swiftLeader Key/ConfigValidator.swiftwhenself-consistency checksTest plan
whenwork identically🤖 Generated with Claude Code