Develop

.github/workflows/build.yml

@@ -0,0 +1,15 @@
+name: Build and Publish
+
+on:
+  push:
+    branches:
+      - master
+      - develop
+  workflow_dispatch:
+
+jobs:
+  build:
+    uses: mikopbx/.github-workflows/.github/workflows/extension-publish.yml@master
+    with:
+      initial_version: "1.113"
+    secrets: inherit

.gitignore

@@ -0,0 +1 @@
+.DS_Store

App/Controllers/ModuleSmartIVRController.php

@@ -69,6 +69,11 @@ public function indexAction(): void
         ];
         $this->view->moduleCTI2Installed = PbxExtensionModules::count($parameters)>0;
 
+        $parameters = [
+            'conditions'=>'uniqid="ModuleCTIClientV5" and disabled!="1"'
+        ];
+        $this->view->moduleCTI5Installed = PbxExtensionModules::count($parameters)>0;
+
         $options = [
             'extensions' => $forwardingExtensions
         ];

App/Forms/ModuleSmartIVRForm.php

@@ -1,11 +1,22 @@
 <?php
-/**
- * Copyright © MIKO LLC - All Rights Reserved
- * Unauthorized copying of this file, via any medium is strictly prohibited
- * Proprietary and confidential
- * Written by Alexey Portnov, 2 2019
- */
 
+/*
+ * MikoPBX - free phone system for small business
+ * Copyright © 2017-2024 Alexey Portnov and Nikolay Beketov
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along with this program.
+ * If not, see <https://www.gnu.org/licenses/>.
+ */
 namespace Modules\ModuleSmartIVR\App\Forms;
 
 use Phalcon\Forms\Element\Check;
@@ -15,10 +26,8 @@
 use Phalcon\Forms\Element\Text;
 use Phalcon\Forms\Form;
 
-
 class ModuleSmartIVRForm extends Form
 {
-
     public function initialize($entity = null, $options = null)
     {
         $this->add(new Text('server1chost'));
@@ -28,75 +37,91 @@ public function initialize($entity = null, $options = null)
         $this->add(new Text('database'));
         $this->add(
             new Numeric(
-                'number_of_repeat', [
+                'number_of_repeat',
+                [
                 'maxlength'    => 2,
                 'style'        => 'width: 80px;',
                 'defaultValue' => 1,
-            ]
+                ]
             )
         );
 
         // UseSSL
-        $checkAr = ['value' => null];
-        if ($entity->useSSL) {
-            $checkAr = ['checked' => 'checked', 'value' => null];
-        }
-        $this->add(new Check('useSSL', $checkAr));
+        $this->addCheckBox('useSSL', intval($entity->useSSL) === 1);
 
         // Library
         $arrLibraryType = [
             '1.0' => $this->translation->_('module_smivr_LibraryVer1'),
             '2.0' => $this->translation->_('module_smivr_LibraryVer2'),
+            '5.0' => $this->translation->_('module_smivr_LibraryVer5'),
         ];
 
         $library = new Select(
-            'library_1c', $arrLibraryType, [
+            'library_1c',
+            $arrLibraryType,
+            [
             'using'    => [
                 'id',
                 'name',
             ],
             'useEmpty' => false,
             'value'    => $entity->library_1c,
             'class'    => 'ui selection dropdown library-type-select',
-        ]
+            ]
         );
         $this->add($library);
 
         // FailOver Extension
         $extension = new Select(
-            'failover_extension', $options['extensions'], [
+            'failover_extension',
+            $options['extensions'],
+            [
             'using'    => [
                 'id',
                 'name',
             ],
             'useEmpty' => false,
             'class'    => 'ui selection dropdown search forwarding-select',
-        ]
+            ]
         );
         $this->add($extension);
 
         // Timeout Extension
         $extension = new Select(
-            'timeout_extension', $options['extensions'], [
+            'timeout_extension',
+            $options['extensions'],
+            [
             'using'    => [
                 'id',
                 'name',
             ],
             'useEmpty' => false,
             'class'    => 'ui selection dropdown search forwarding-select',
-        ]
+            ]
         );
         $this->add($extension);
 
-        // debug_mode
-        $checkAr = ['value' => null];
-        if ($entity->debug_mode) {
-            $checkAr = ['checked' => 'checked', 'value' => null];
-        }
-        $this->add(new Check('debug_mode', $checkAr));
+        $this->addCheckBox('debug_mode', intval($entity->debug_mode) === 1);
 
         $this->add(new Numeric('last_responsible_time'));
         $this->add(new Numeric('last_responsible_duration'));
+    }
 
+    /**
+     * Adds a checkbox to the form field with the given name.
+     * Can be deleted if the module depends on MikoPBX later than 2024.3.0
+     *
+     * @param string $fieldName The name of the form field.
+     * @param bool $checked Indicates whether the checkbox is checked by default.
+     * @param string $checkedValue The value assigned to the checkbox when it is checked.
+     * @return void
+     */
+    public function addCheckBox(string $fieldName, bool $checked, string $checkedValue = 'on'): void
+    {
+        $checkAr = ['value' => null];
+        if ($checked) {
+            $checkAr = ['checked' => $checkedValue,'value' => $checkedValue];
+        }
+        $this->add(new Check($fieldName, $checkAr));
     }
-}
+}

App/Views/index.volt

@@ -12,6 +12,11 @@
         <label>{{ t._('module_smivr_Library1CType') }}</label>
         {{ form.render('library_1c') }}
     </div>
+    {% if moduleCTI5Installed %}
+        <div class="ui positive message only-five-generation">{{ t._("module_smivr_WeGetSettingsFromCTIClientV5") }}</div>
+    {% else %}
+        <div class="ui negative message only-five-generation">{{ t._("module_smivr_LibraryVer5NotInstalled") }}</div>
+    {% endif %}
     {% if moduleCTI2Installed %}
         <div class="ui positive message only-second-generation">{{ t._("module_smivr_WeGetSettingsFromCTIClient") }}</div>
     {% else %}

Lib/AGICallLogic.php

@@ -32,6 +32,8 @@ class AGICallLogic extends PbxExtensionBase
     private string $contextInternal = 'internal';
     private string $number;
     private array $messages = [];
+    private int $maxMessagesCount = 100; // Maximum number of messages to store
+    private int $maxMessageLength = 1024; // Maximum length of each message
     private WebService1C $web_service_1C;
     private $count_of_repeat_ivr;
     private $timeout_extension;
@@ -271,12 +273,17 @@ private function text2speech($arr_text_to_speech): ?string
             'logger' => $this->logger,
         ];
 
-        switch ($ttsSettings->tts_service) {
-            case 'Yandex':
+        switch (strtoupper($ttsSettings->tts_service)) {
+            case 'YANDEX':
             {
                 $tts = new YandexTTS($settings);
                 break;
             }
+            case 'MIKO':
+            {
+                $tts = new MikoTTS($settings);
+                break;
+            }
             case 'CRT':
             {
                 $tts = new SpeechProTTS($settings);
@@ -306,9 +313,20 @@ private function text2speech($arr_text_to_speech): ?string
      */
     public function Verbose($value): void
     {
+        // Truncate value if it's a string and too long
+        if (is_string($value) && strlen($value) > $this->maxMessageLength) {
+            $value = substr($value, 0, $this->maxMessageLength) . '... [truncated]';
+        }
+
+        // Add to messages array, keeping only the most recent ones
         $this->messages[] = $value;
+        if (count($this->messages) > $this->maxMessagesCount) {
+            array_shift($this->messages);
+        }
+
         if ($this->agi !== null) {
-            $this->agi->verbose('SMART IVR VERBOSE: ' . escapeshellarg($value), 3);
+            $truncated_value = is_string($value) ? $value : json_encode($value);
+            $this->agi->verbose('SMART IVR VERBOSE: ' . escapeshellarg($truncated_value), 3);
         }
     }
 
@@ -397,42 +415,44 @@ private function getIVRPhrase($phraseId, $extension = null): string
             }
             case 'ConnectionToExtension':
             {
-                $parameters      = [
-                    'models'     => [
-                        'Extensions' => Extensions::class,
-                    ],
-                    'columns'    => [
-                        'username' => 'Users.username',
-                    ],
-                    'conditions' => 'Extensions.number = :extension: AND Extensions.is_general_user_number=1',
-                    'bind'       => [
-                        'extension' => $extension,
-                    ],
-                    'joins'      => [
-                        'Users' => [
-                            0 => Users::class,
-                            1 => 'Users.id=Extensions.userid',
-                            2 => 'Users',
-                            3 => 'INNER',
+                $userName = $this->web_service_1C->getUserInfoV5($extension);
+                if($userName === null){
+                    $parameters      = [
+                        'models'     => [
+                            'Extensions' => Extensions::class,
                         ],
-                    ],
-                    'limit'      => 1,
-                ];
-                $query      = $this->di->get('modelsManager')->createBuilder($parameters)->getQuery();
-                $extensions = $query->execute();
-                $extensionRecord = null;
-                foreach ($extensions as $record) {
-                    $extensionRecord = $record;
-                    break;
-                }
-                $abonentName     = '';
-                if ($extensionRecord) {
-                    $abonentName = $extensionRecord->username;
+                        'columns'    => [
+                            'username' => 'Users.username',
+                        ],
+                        'conditions' => 'Extensions.number = :extension: AND Extensions.is_general_user_number=1',
+                        'bind'       => [
+                            'extension' => $extension,
+                        ],
+                        'joins'      => [
+                            'Users' => [
+                                0 => Users::class,
+                                1 => 'Users.id=Extensions.userid',
+                                2 => 'Users',
+                                3 => 'INNER',
+                            ],
+                        ],
+                        'limit'      => 1,
+                    ];
+                    $query      = $this->di->get('modelsManager')->createBuilder($parameters)->getQuery();
+                    $extensions = $query->execute();
+                    $extensionRecord = null;
+                    foreach ($extensions as $record) {
+                        $extensionRecord = $record;
+                        break;
+                    }
+                    if ($extensionRecord) {
+                        $userName = $extensionRecord->username;
+                    }
                 }
-                if (empty($abonentName)) {
+                if (empty($userName)) {
                     $resultText = 'Соединяю с номером ' . $extension;
                 } else {
-                    $resultText = 'Соединяю с сотрудником ' . $abonentName;
+                    $resultText = 'Соединяю с сотрудником ' . $userName;
                 }
                 break;
             }