Skip to content

Customer.retrieve should not need a refresh_token as a parameter#3

Open
rebelvc wants to merge 2 commits into
milesmatthias:masterfrom
rebelvc:master
Open

Customer.retrieve should not need a refresh_token as a parameter#3
rebelvc wants to merge 2 commits into
milesmatthias:masterfrom
rebelvc:master

Conversation

@rebelvc
Copy link
Copy Markdown
Contributor

@rebelvc rebelvc commented Apr 23, 2015

No description provided.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 85.62% when pulling a36a4c5 on rebelvc:master into aa83930 on milesmatthias:master.

@milesmatthias
Copy link
Copy Markdown
Owner

Thanks @rebelvc. I think we actually need this.

Synapse will give an "Error in OAuth20Authentication" error if the access token has expired, at which point they expect you to use the refresh_token to get a new access_token and refresh_token: http://synapsepay.readme.io/v1.0/docs/authentication-refresh

One of the things that's on the todo list is to automatically refresh the token and try again when our code encounters the OAuth error. Without passing the refresh token, we wouldn't be able to automatically do that.

If you'd like to work on that and send a PR, that would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants