Skip to content

async plugin: adding second parameter to support naming a global callbac... #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhrisse wants to merge 1 commit into
base: master
Choose a base branch
from
Open

async plugin: adding second parameter to support naming a global callbac... #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,28 @@ define(function(){
return url + param +'='+ id;
}

function uid() {
_uid += 1;
return '__async_req_'+ _uid +'__';
function parse(name) {
var parts = name.split(':');
return parts[1];
}

function uid(name) {
var glob = parse(name);
if(glob === undefined) {
_uid += 1;
return '__async_req_'+ _uid +'__';
} else {
return glob;
}
}

return{
load : function(name, req, onLoad, config){

if(config.isBuild){
onLoad(null); //avoid errors on the optimizer
}else{
var id = uid();
var id = uid(name);
//create a global variable that stores onLoad so callback
//function can define new module after async load
window[id] = onLoad;
Expand Down