Skip to content

fix: disable APF feature flag to prevent readyz-blocking informers #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scotwells wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disable APF feature flag to prevent readyz-blocking informers #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions cmd/ipam/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,17 @@ func NewIPAMServerOptions() *IPAMServerOptions {
opts.RecommendedOptions.Admission.RecommendedPluginOrder = []string{}
opts.RecommendedOptions.Admission.DefaultOffPlugins = nil

// API Priority and Fairness is enforced by the main kube-apiserver; a
// delegating aggregated apiserver does not run its own APF. Disabling it
// here (before ApplyTo) prevents FeatureOptions.ApplyTo from calling
// utilflowcontrol.New(), which would register FlowSchema and
// PriorityLevelConfiguration informers on the shared informer factory.
// Those informers are counted by the informer-sync readyz check and never
// reliably sync without flowcontrol.apiserver.k8s.io access, blocking
// readyz indefinitely. Nil-ing genericConfig.FlowControl after ApplyTo is
// insufficient because the informers are already registered by then.
opts.RecommendedOptions.Features.EnablePriorityAndFairness = false

return opts
}

Expand Down Expand Up @@ -231,12 +242,6 @@ func (o *IPAMServerOptions) Config() (*ipamapiserver.Config, error) {
return nil, fmt.Errorf("apply recommended options: %w", err)
}

// Delegating aggregated apiservers defer API Priority and Fairness to the
// main kube-apiserver. ApplyTo may re-initialize FlowControl, so nil it
// out here (after ApplyTo) to prevent the FlowSchema and
// PriorityLevelConfiguration informers from blocking readyz.
genericConfig.FlowControl = nil

codec := ipamapiserver.Codecs.LegacyCodec(ipamapiserver.Scheme.PrioritizedVersionsAllGroups()...)

pgGetter, err := pgstore.NewRESTOptionsGetter(o.PostgresDSN)
Expand Down
Loading