feat(search): support wildcards in ResourceIndexPolicy field paths#100
Merged
Conversation
5 tasks
937a00e to
e6f21aa
Compare
e6f21aa to
76d6b4c
Compare
Contributor
Author
|
hmm... https://github.com/milo-os/search/actions/runs/26234928863/job/77205338583?pr=100 ❯ task generate
Rendering PlantUML diagrams...
✅ Diagrams rendered in /Users/alex/Developer/datum/search/docs/diagrams
Generated files:
ResourceIndexerScaling.png
SearchServiceContainers.png
SearchServiceContext.png
Generating deepcopy and object files...
Generating RBAC rules for the controllers...
🔄 Generating Kubernetes OpenAPI definitions...
Using code-generator from: /Users/alex/go/pkg/mod/k8s.io/code-generator@v0.35.2
Generating deepcopy...
Generating deepcopy code for 1 targets
Generating OpenAPI definitions...
Code generation complete!
Generated:
- Deepcopy functions: pkg/apis/search/v1alpha1/zz_generated.deepcopy.go
- OpenAPI: pkg/generated/openapi/
✅ OpenAPI generation complete
❯ git st
## feat/enable-search-in-lists...origin/feat/enable-search-in-listsThis task doesn't change any files for me locally. |
Contributor
Author
|
@JoseSzycho ok thanks! regenerated with the new latest image. I think it'd be a good idea to pin a specific tag #101 |
JoseSzycho
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97. Depends on #96.
Summary
ResourceIndexPolicy.spec.fields[].pathnow accepts[*]to mean "every element of this array." For example,.spec.ports[*].namemakes every port'snamesearchable, not just the one at index 0. The controller translates[*]-bearing paths to MeilisearchsearchableAttributesby stripping the[*]segment; Meilisearch traverses arrays automatically given a dotted path (spec.ports.name).