Skip to content

feat(search): support wildcards in ResourceIndexPolicy field paths#100

Merged
savme merged 3 commits into
mainfrom
feat/enable-search-in-lists
May 22, 2026
Merged

feat(search): support wildcards in ResourceIndexPolicy field paths#100
savme merged 3 commits into
mainfrom
feat/enable-search-in-lists

Conversation

@savme

@savme savme commented May 21, 2026

Copy link
Copy Markdown
Contributor

Closes #97. Depends on #96.

Summary

ResourceIndexPolicy.spec.fields[].path now accepts [*] to mean "every element of this array." For example, .spec.ports[*].name makes every port's name searchable, not just the one at index 0. The controller translates [*]-bearing paths to Meilisearch searchableAttributes by stripping the [*] segment; Meilisearch traverses arrays automatically given a dotted path (spec.ports.name).

@savme savme force-pushed the feat/enable-search-in-lists branch from e6f21aa to 76d6b4c Compare May 21, 2026 15:13
@savme savme marked this pull request as ready for review May 21, 2026 15:13
@savme savme requested a review from JoseSzycho May 21, 2026 15:14
@savme

savme commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

hmm... https://github.com/milo-os/search/actions/runs/26234928863/job/77205338583?pr=100

❯ task generate
Rendering PlantUML diagrams...


✅ Diagrams rendered in /Users/alex/Developer/datum/search/docs/diagrams

Generated files:
ResourceIndexerScaling.png
SearchServiceContainers.png
SearchServiceContext.png
Generating deepcopy and object files...
Generating RBAC rules for the controllers...
🔄 Generating Kubernetes OpenAPI definitions...
Using code-generator from: /Users/alex/go/pkg/mod/k8s.io/code-generator@v0.35.2
Generating deepcopy...
Generating deepcopy code for 1 targets
Generating OpenAPI definitions...

Code generation complete!

Generated:
  - Deepcopy functions: pkg/apis/search/v1alpha1/zz_generated.deepcopy.go
  - OpenAPI: pkg/generated/openapi/
✅ OpenAPI generation complete

❯ git st
## feat/enable-search-in-lists...origin/feat/enable-search-in-lists

This task doesn't change any files for me locally.

@JoseSzycho

JoseSzycho commented May 21, 2026

Copy link
Copy Markdown
Contributor

oh @savme this already happened once to me, is because you have a miss match between your plantuml version and the one used by the action.

plantuml/plantuml:latest \

You should update the version to the latest in your dev environment

@savme

savme commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

@JoseSzycho ok thanks! regenerated with the new latest image. I think it'd be a good idea to pin a specific tag #101

@github-project-automation github-project-automation Bot moved this from Backlog to Ready in Searching Resources in Milo May 22, 2026
@savme savme merged commit fdc1026 into main May 22, 2026
6 checks passed
@savme savme deleted the feat/enable-search-in-lists branch May 22, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support [*] wildcard in ResourceIndexPolicy field paths

2 participants