fixed NVM installation issue#19
Open
bongani-m wants to merge 2 commits intominamarkham:masterfrom
bongani-m:nvm-fix
Open
fixed NVM installation issue#19bongani-m wants to merge 2 commits intominamarkham:masterfrom bongani-m:nvm-fix
bongani-m wants to merge 2 commits intominamarkham:masterfrom
bongani-m:nvm-fix
Conversation
|
It still is skipping the NVM install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While install on a fresh Mojave installation I ran into two issues: 1) NVM was getting skipped and 2) installation did work because
~/.bash_profiledid not exist.This fix resolves both issues by checking for existance of
NVM_DIRto see ifnvmis installed and creating the~/.bash_profileif it doesn't already exist. It also loads nvm for the session to insure that node and the npm packages get installed gets installed. Also NVM gets a version bumpFixes #7