MOBILE-258: Fix regex for operationDomain path#744
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the operations-domain validation to correctly handle percent-encoding in the optional path prefix, preventing malformed % escapes from passing validation and later breaking URL construction at request time.
Changes:
- Tighten
PATH_PREFIX_REGEXto allow only unreserved characters or complete%HHpercent-encoded octets in path segments. - Add regression tests covering valid percent-encoding and rejecting incomplete/non-hex escapes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/src/main/java/cloud/mindbox/mobile_sdk/SdkValidation.kt | Updates the path-prefix regex and KDoc to reject bare/incomplete % while allowing valid %HH escapes. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/SdkValidationDomainTest.kt | Adds test coverage for percent-encoded path segments and invalid percent escapes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-258