Skip to content

Delete POST knowledge_bases/<name>/completions endpoint #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StpMax wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −23
Open

Delete POST knowledge_bases/<name>/completions endpoint #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df77abc
del kb/completions endpoint
StpMax Apr 3, 2026
69c6e08
test
StpMax Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions mindsdb_sdk/connectors/rest_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,14 +424,6 @@ def create_knowledge_base(self, project: str, data):

return r.json()

def knowledge_base_completion(self, project: str, knowledge_base_name, payload):
r = self.session.post(
self.url + f'/api/projects/{project}/knowledge_bases/{knowledge_base_name}/completions',
json=payload
)
_raise_for_status(r)
return r.json()

def get_config(self):
"""
Get MindsDB configuration.
Expand Down
5 changes: 0 additions & 5 deletions mindsdb_sdk/knowledge_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,6 @@ def insert_query(self, data: Query, params: dict = None):
data=data
)

def completion(self, query, **data):
data['query'] = query

return self.api.knowledge_base_completion(self.project.name, self.name, data)


class KnowledgeBases(CollectionBase):
"""
Expand Down
10 changes: 0 additions & 10 deletions tests/test_sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,16 +1301,6 @@ def check_project_kb(self, project, database, mock_get, mock_del, mock_post, moc
},
}}}

# completion
kb.completion('hi', type='chat', llm_model='gpt-4')
args, kwargs = mock_post.call_args
assert args[0] == f'{DEFAULT_CLOUD_API_URL}/api/projects/{project.name}/knowledge_bases/{kb.name}/completions'
assert kwargs == {'json': {
'query': 'hi',
'type': 'chat',
'llm_model': 'gpt-4',
}}

# drop
project.knowledge_bases.drop('kb2')

Expand Down
Loading