Implement Code of Conduct handling in player configuration#682
Draft
emmanuelvlad wants to merge 1 commit intominekube:masterfrom
Draft
Implement Code of Conduct handling in player configuration#682emmanuelvlad wants to merge 1 commit intominekube:masterfrom
emmanuelvlad wants to merge 1 commit intominekube:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new event-driven mechanism to handle the Code of Conduct (CoC) acceptance flow during the backend configuration stage for Minecraft 1.21.9+ clients.
The main changes add extensibility for sending and handling CoC packets, ensuring the proxy can pause configuration until the player accepts the CoC, and cleanly resume configuration afterward.
I am not entirely sure this is the best way to implement it. Let me know if there's a better way to do it, feedback appreciated!
Here is an implementation example on a proxy: