Different leaderboard error messages instead of throwing stack traces at users faces#29
Merged
rlaphoenix merged 2 commits intominerva-archive:masterfrom Mar 8, 2026
Merged
Conversation
Electrenator
changed the title
Electrenator
changed the title
rlaphoenix
reviewed
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly made the user not see a whole stack trace when the connection to the leader board happens to error out in whatever way. Seems more user friendly to give a message here instead of throwing a stack trace at them given we likely know about what is going wrong there. Few specific custom error messages with that can't hurt.
Might add more descriptive description later, too tired for that now. Also slightly unrelated but if there are some other things I could help with with this let me know, been fun messing around a bit with this code base. Slightly eyeing the ctrl+c error / related
maybeunclean shutdown rn but haven't figured that one out yet