Fixed headers being printed when using SaveAsAsync despite ExcelIgnore property set to true on DynamicExcelColumn

src/MiniExcel/OpenXml/ExcelOpenXmlSheetWriter.Async.cs

@@ -362,22 +362,21 @@ private static async Task WriteColumnsWidthsAsync(MiniExcelAsyncStreamWriter wri
 
         private async Task PrintHeaderAsync(MiniExcelAsyncStreamWriter writer, List<ExcelColumnInfo> props, CancellationToken cancellationToken = default)
         {
-            var xIndex = 1;
-            var yIndex = 1;
+            const int yIndex = 1;
             await writer.WriteAsync(WorksheetXml.StartRow(yIndex));
 
+            var xIndex = 1;
             foreach (var p in props)
             {
-                cancellationToken.ThrowIfCancellationRequested();
-
-                if (p == null)
+                //reason : https://github.com/mini-software/MiniExcel/issues/142
+                if (p != null)
                 {
-                    xIndex++; //reason : https://github.com/mini-software/MiniExcel/issues/142
-                    continue;
-                }
+                    if (p.ExcelIgnore)
+                        continue;
 
-                var r = ExcelOpenXmlUtils.ConvertXyToCell(xIndex, yIndex);
-                await WriteCellAsync(writer, r, columnName: p.ExcelColumnName);
+                    var r = ExcelOpenXmlUtils.ConvertXyToCell(xIndex, yIndex);
+                    await WriteCellAsync(writer, r, columnName: p.ExcelColumnName);
+                }
                 xIndex++;
             }
 

src/MiniExcel/WriteAdapter/AsyncEnumerableWriteAdapter.cs

@@ -73,16 +73,16 @@ private static async IAsyncEnumerable<CellWriteInfo> GetRowValuesAsync(T current
             foreach (var prop in props)
             {
                 column++;
-
-                if (prop is null)
-                    continue;
 
-                yield return currentValue switch
+                if (prop is { ExcelIgnore: false })
                 {
-                    IDictionary<string, object> genericDictionary => new CellWriteInfo(genericDictionary[prop.Key.ToString()], column, prop),
-                    IDictionary dictionary => new CellWriteInfo(dictionary[prop.Key], column, prop),
-                    _ => new CellWriteInfo(prop.Property.GetValue(currentValue), column, prop)
-                };
+                    yield return currentValue switch
+                    {
+                        IDictionary<string, object> genericDictionary => new CellWriteInfo(genericDictionary[prop.Key.ToString()], column, prop),
+                        IDictionary dictionary => new CellWriteInfo(dictionary[prop.Key], column, prop),
+                        _ => new CellWriteInfo(prop.Property.GetValue(currentValue), column, prop)
+                    };
+                }
             }
         }
 

tests/MiniExcelTests/MiniExcelIssueAsyncTests.cs

@@ -220,7 +220,7 @@
 
     private class Issue243Dto
     {
         public string Name { get; set; }
         public int Age { get; set; }
         public DateTime InDate { get; set; }
     }
@@ -292,7 +292,7 @@
 
     private class Issue241Dto
     {
         public string Name { get; set; }
 
         [ExcelFormat("MM dd, yyyy")]
         public DateTime InDate { get; set; }
@@ -359,11 +359,11 @@
         var sheets = new DataSet();
 
         var users = JsonConvert.DeserializeObject<DataTable>(JsonConvert.SerializeObject(new[] { new { Name = "Jack", Age = 25 }, new { Name = "Mike", Age = 44 } }));
         users.TableName = "users";
         sheets.Tables.Add(users);
 
         var department = JsonConvert.DeserializeObject<DataTable>(JsonConvert.SerializeObject(new[] { new { ID = "01", Name = "HR" }, new { ID = "02", Name = "IT" } }));
         department.TableName = "department";
         sheets.Tables.Add(department);
 
         var rowsWritten = await MiniExcel.SaveAsAsync(path, sheets);
@@ -1853,4 +1853,40 @@
         public double? 波段 { get; set; }
         public double? 當沖 { get; set; }
     }
-}
+
+    [Fact]
+    public async Task TestIssue584()
+    {
+        var excelconfig = new OpenXmlConfiguration
+        {
+            DynamicColumns =
+            [
+                new DynamicExcelColumn("Id") { Ignore = true }
+            ]
+        };
+
+        await using var conn = Db.GetConnection();
+        conn.Open();
+
+        await using var cmd = conn.CreateCommand();
+        cmd.CommandText =
+            """
+            WITH test('Id', 'Name') AS (
+                VALUES 
+                    (1, 'test1'), 
+                    (2, 'test2'), 
+                    (3, 'test3')
+                )
+            SELECT * FROM test;
+            """;
+
+        await using var reader = cmd.ExecuteReader();
+
+        using var path = AutoDeletingPath.Create();
+        await MiniExcel.SaveAsAsync(path.FilePath, reader, configuration: excelconfig, overwriteFile: true);
+
+        var rows = (await MiniExcel.QueryAsync(path.FilePath)).ToList();
+        Assert.All(rows, x => Assert.Single(x));
+        Assert.Equal("Name", rows[0].A);
+    }
+}