Skip to content

Add bucket compression admin actions. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshavardhana merged 1 commit into from
Jul 12, 2026
Merged

Add bucket compression admin actions. #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions policy/admin-action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,13 @@ const (
// GetBucketQuotaAdminAction - allow getting bucket quota
GetBucketQuotaAdminAction = "admin:GetBucketQuota"

// Bucket compression Actions

// SetBucketCompressionAdminAction - allow setting per-bucket compression config
SetBucketCompressionAdminAction = "admin:SetBucketCompression"
// GetBucketCompressionAdminAction - allow getting per-bucket compression config
GetBucketCompressionAdminAction = "admin:GetBucketCompression"

// Bucket Target admin Actions

// SetBucketTargetAction - allow setting bucket target
Expand Down Expand Up @@ -355,6 +362,8 @@ var SupportedAdminActions = map[AdminAction]struct{}{
ListUserPoliciesAdminAction: {},
SetBucketQuotaAdminAction: {},
GetBucketQuotaAdminAction: {},
SetBucketCompressionAdminAction: {},
GetBucketCompressionAdminAction: {},
SetBucketTargetAction: {},
GetBucketTargetAction: {},
ReplicationDiff: {},
Expand Down Expand Up @@ -427,15 +436,17 @@ var SupportedAdminActions = map[AdminAction]struct{}{
// against the target bucket. All other admin actions are resource-less;
// any Resource specified in the statement is ignored for them.
var AdminActionsWithResource = map[AdminAction]struct{}{
SetBucketQuotaAdminAction: {},
GetBucketQuotaAdminAction: {},
SetBucketTargetAction: {},
GetBucketTargetAction: {},
ReplicationDiff: {},
ImportBucketMetadataAction: {},
ExportBucketMetadataAction: {},
HealAdminAction: {},
InventoryControlAction: {},
SetBucketQuotaAdminAction: {},
GetBucketQuotaAdminAction: {},
SetBucketCompressionAdminAction: {},
GetBucketCompressionAdminAction: {},
SetBucketTargetAction: {},
GetBucketTargetAction: {},
ReplicationDiff: {},
ImportBucketMetadataAction: {},
ExportBucketMetadataAction: {},
HealAdminAction: {},
InventoryControlAction: {},
}

// HasResource reports whether this admin action operates on a bucket resource.
Expand Down
2 changes: 2 additions & 0 deletions policy/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ var DefaultPolicies = []struct {
// Bucket admin
SetBucketQuotaAdminAction,
GetBucketQuotaAdminAction,
SetBucketCompressionAdminAction,
GetBucketCompressionAdminAction,
// Tiers
SetTierAction,
ListTierAction,
Expand Down
2 changes: 2 additions & 0 deletions policy/policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2793,6 +2793,8 @@ func TestAdminActionHasResource(t *testing.T) {
bucketScoped := []AdminAction{
SetBucketQuotaAdminAction,
GetBucketQuotaAdminAction,
SetBucketCompressionAdminAction,
GetBucketCompressionAdminAction,
SetBucketTargetAction,
GetBucketTargetAction,
ReplicationDiff,
Expand Down
Loading