feat: add ActionType generic constraint for policy actions#245
Conversation
ActionType is a union of the policy action types (Action, AdminAction, STSAction, KMSAction, TableAction, VectorsAction, MemoryAction). It lets generic auth helpers accept any typed action without per-call conversion to Action, while a bare string stays excluded.
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Adds
policy.ActionType, a generic constraint that is the union of the policyaction types:
It lets generic auth helpers accept any typed action without forcing callers to
convert to
Actionat each call site, while a barestringstays excluded(so it's tighter than
~string).Motivation
Consumers (e.g. MinIO AIStor) have request-auth helpers typed on
policy.Action.As more service action types are added (
TableAction,VectorsAction,MemoryAction, …), callers must wrap each typed constant inpolicy.Action(...).A shared constraint lets those helpers become generic over
ActionTypeand dropthe per-call conversions, keeping the single
Actionconversion at the boundarywhere the policy engine evaluates.
Changes
policy/action-constraint.go— theActionTypeunion constraint.No behavior change; type-level addition only.
go build ./...andgo vet ./policy/...pass.