fix: Object.ForEach now continues the loop after consuming a skipped value#92
Merged
harshavardhana merged 1 commit intominio:masterfrom Jun 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue in Object.ForEach that occurs when a non-nil onlyKeys map is provided. Specifically, if the current key isn't found in the map, the code correctly skips over its associated value but then fails to continue to the next iteration. As a result, the remainder of the loop runs and mistakenly consumes the subsequent key. This update ensures that the loop properly skips the rest of the current iteration when a key is absent.