Refactors ColorTags#9
Open
Glinkis wants to merge 4 commits intominiwolf:masterfrom
Glinkis:ColorTags-refactor
Open
Refactors ColorTags#9Glinkis wants to merge 4 commits intominiwolf:masterfrom Glinkis:ColorTags-refactor
Glinkis wants to merge 4 commits intominiwolf:masterfrom
Glinkis:ColorTags-refactor
Conversation
Fix indentation.
miniwolf
requested changes
Jun 20, 2018
Engine/src/mini/font/ColorTags.java
Outdated
| color.a = Integer.parseInt(colorStr.subSequence(6, 8).toString(), 16) / 255f; | ||
| } | ||
| readHexColor(colorStr); | ||
| return; |
Engine/src/mini/font/ColorTags.java
Outdated
| } else if (colorStr.length() == 4) { | ||
| color.a = Integer.parseInt(Character.toString(colorStr.charAt(3)), 16) / 15f; | ||
| } | ||
| color.a = 0; |
Owner
There was a problem hiding this comment.
That is wrong, this needs to be a 1. If you look at how color.set was used previously.
Engine/src/mini/font/ColorTags.java
Outdated
| } else if (colorStr.length() == 4) { | ||
| readColorValue(colorStr, 3); | ||
| } else { | ||
| color.a = 0; |
Owner
There was a problem hiding this comment.
Should be set to 1 otherwise we loose the color.
Engine/src/mini/font/ColorTags.java
Outdated
| if (baseAlpha != -1) { | ||
| color.a = baseAlpha; | ||
| } else if (colorStr.length() == 4) { | ||
| readColorValue(colorStr, 3); |
Owner
There was a problem hiding this comment.
you are forgetting to put color.a = readColorValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.