chore: version fmcd in tandem with fedimint#15
Open
okjodom wants to merge 1 commit intominmoto:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request implements comprehensive observability and testing infrastructure for the fmcd (Fedimint Client Daemon) project, introducing event-driven architecture, webhooks, metrics collection, and extensive test coverage.
Key Changes:
- Added event bus system with handlers for logging and metrics collection
- Implemented webhook notification system with security features (SSRF protection, HMAC signatures)
- Created observability layer with request correlation, logging configuration, and sensitive data sanitization
- Introduced database instrumentation for query tracking and performance monitoring
- Added extensive integration and unit tests across multiple modules
- Refactored error handling with categorized error types
- Implemented health check endpoints with component-level monitoring
Reviewed Changes
Copilot reviewed 117 out of 134 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/mod.rs | Module declarations for integration tests |
| tests/integration/phase2_observability_tests.rs | Comprehensive observability integration tests for event system |
| tests/integration/event_coverage_test.rs | Event emission and coverage tests for various event types |
| tests/integration/websocket_test.rs | WebSocket message format tests |
| tests/integration/api_test.rs | API and state integration tests |
| tests/config_tests.rs | Configuration management tests |
| tests/common/mod.rs | Test utilities and fixtures |
| tests/auth_tests.rs | Authentication and HMAC tests |
| src/webhooks/* | Webhook notification system with retry logic and security |
| src/observability/* | Correlation IDs, logging, and data sanitization |
| src/metrics/* | Prometheus metrics collection |
| src/health/* | Health check endpoints |
| src/events/* | Event bus and handler implementations |
| src/error/* | Enhanced error handling with categories |
| src/database/* | Database instrumentation layer |
| src/state.rs | Refactored application state with FmcdCore integration |
| src/lib.rs | Library structure with feature flags |
| src/core/* | Core business logic modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For every major version of fedimint released, we will cut a release of
FMCD