feat: align fmcd behavior with fedimint-client 0.8#7
Merged
Conversation
The fmcd API now provides: - Automatic invoice monitoring - Using fedimint's native subscribe_ln_receive - Real-time streaming updates - SSE endpoints for live invoice status - Bulk status queries - Efficient multi-invoice management - Full fedimint 0.8 alignment - Native behavior matching the underlying client feat: simplify fmcd api surface
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes fmcd to align with fedimint-client 0.8 behavior, introducing automatic invoice monitoring, real-time streaming, and bulk operations while removing deprecated external pubkey APIs.
- Replaces manual invoice polling with automatic fedimint native monitoring using
subscribe_ln_receive - Adds real-time SSE endpoints for live invoice status streaming and bulk operations
- Removes deprecated external pubkey tweaked APIs and await methods
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/webhooks/invoice.rs |
New webhook notification system for invoice events with exponential backoff |
src/router/handlers/ln/invoice.rs |
Enhanced invoice creation with automatic monitoring and unified status tracking |
src/router/handlers/ln/status.rs |
New unified status endpoints supporting bulk queries and operation ID lookup |
src/router/handlers/ln/stream.rs |
SSE streaming endpoints for real-time invoice monitoring and global events |
src/router/ws.rs |
Updated WebSocket routing to use new status endpoints and correlation tracking |
src/main.rs |
Updated REST API routes to align with fedimint 0.8 endpoint structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fmcdAPI now provides: