Conversation
lc10934
reviewed
Apr 12, 2025
| { | ||
| size_t left = currInd * 2 + 1; | ||
| size_t right = currInd * 2 + 2; | ||
| T newLargest = currInd; |
Collaborator
There was a problem hiding this comment.
newLargest is an index so should be type size_t
lc10934
approved these changes
Apr 12, 2025
echavemann
reviewed
Apr 12, 2025
| } | ||
|
|
||
| const T &pop_front() | ||
| T pop_front() |
echavemann
reviewed
Apr 12, 2025
| size_t size() const { return sz; } | ||
|
|
||
| private: | ||
| void refactor(size_t currInd) |
There was a problem hiding this comment.
not sure if refactor is a great name for this but up to you
echavemann
reviewed
Apr 12, 2025
| maxSz = newSize; | ||
| } | ||
|
|
||
| std::unique_ptr<T[]> tree; |
There was a problem hiding this comment.
simiar thing here, id probably use a std::array instead fo a C style array
echavemann
reviewed
Apr 12, 2025
| private: | ||
| void refactor(size_t currInd) | ||
| { | ||
| size_t left = currInd * 2 + 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.