add the ability to set some metadata to a request#4
Open
jayztemplier wants to merge 2 commits intomirego:masterfrom
Open
add the ability to set some metadata to a request#4jayztemplier wants to merge 2 commits intomirego:masterfrom
jayztemplier wants to merge 2 commits intomirego:masterfrom
Conversation
Author
MCAWSS3Client.m
Outdated
Member
There was a problem hiding this comment.
Won't setDefaultHeader: set that data for this and all following requests? It's fine to use it for values that will be overwritten every time like x-amz-security-token but I'm not sure it's the right thing to do for user defined metadata.
I would suggest adding them to the NSMutableURLRequest. What do you think?
Author
There was a problem hiding this comment.
I agree, it needs more refactoring first then since we need to include those header params when we construct the string to sign. Working on it.
Author
|
It's a little bit more code but it works and set the metadata in the request headers instead of the default headers. Thanks for the feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed those instruction to be able to add some metadata in a put request:
http://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPUT.html
Example: