Fix (minor) UB due to signed overflow with unary minus#1
Open
maroneze wants to merge 1 commit intomirtoto:masterfrom
Open
Fix (minor) UB due to signed overflow with unary minus#1maroneze wants to merge 1 commit intomirtoto:masterfrom
maroneze wants to merge 1 commit intomirtoto:masterfrom
Conversation
The minus operator was applied to a long long variable _before_ casting to unsigned, so technically there was an UB (in the words of undefined behavior sanitizer, "negation of LLONG_MIN cannot be represented in type 'long long'").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minus operator was applied to a long long variable before casting to unsigned, so technically there was an UB (in the words of undefined behavior sanitizer, "negation of LLONG_MIN cannot be represented in type 'long long'").
Frama-C/Eva showed it thanks to the test
test_long_long_dec_min.