Fix architecture on Linux aarch64#17
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the download_release function in lib/utils.bash to map the aarch64 architecture to arm64 for release file naming. Feedback suggests improving the function's robustness by declaring variables such as ARCH, OS, and RELEASE_FILE as local to avoid global scope conflicts and potential side effects in the shell environment.
| if [ "$ARCH" == "aarch64" ]; then | ||
| ARCH="arm64" | ||
| fi |
There was a problem hiding this comment.
The variables ARCH, OS, and RELEASE_FILE are not declared as local within the download_release function. In asdf plugins, which are often sourced into the main shell process, global variables can lead to unexpected side effects or conflicts with other plugins or the user's environment. It is recommended to add these variables to the local declaration at the beginning of the function (line 37) to ensure they are properly scoped.
2 participants
No description provided.