feat: install default cloud SDK components#5
Open
flou wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to automatically install a predefined set of Google Cloud SDK components after installation by reading component IDs from a .default-cloud-sdk-components file. The review feedback highlights several critical improvements: validating component names to prevent command injection, handling Windows-specific binary names (gcloud.cmd) and configuration paths (%APPDATA%), and correcting the os.execute status check to ensure robust error handling across Lua environments.
flou
force-pushed
the
default-sdk-components
branch
from
e1ac027 to
f4ea01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for installing default Google Cloud SDK components as part of the gcloud installation flow in the vfox plugin (like
gke-gcloud-auth-plugin).This functionality already existed in the asdf plugin, but was missing from the vfox implementation.
Fixes #4