Merged
Conversation
jacobsjo
approved these changes
Mar 3, 2025
KKW557
force-pushed
the
banner-patterns-renderer
branch
from
4d25921 to
848faf9
Compare
Contributor
Author
|
obviously its going to involve item rendering, so ill just add this embarrassing although the rendering of structure is right direction, but item is reversed. because #51 merged, i have to fix it on item rendering. after whether to sync game's uv is up to you guys and i discover a problem const item1 = ItemStack.fromString('white_banner[hide_additional_tooltip={}, banner_patterns=[]]')and const item2 = ItemStack.fromString('white_banner[hide_additional_tooltip={},banner_patterns=[]]')result is different
so |
KokeCacao
pushed a commit
to KokeCacao/deepslate
that referenced
this pull request
Jul 7, 2025
* Add colored banner * Add colored banners * Add banner patterns renderer * Reduce duplicate code * Fix https://github.com/misode/deepslate/actions/runs/13647649870/job/38149365256?pr=52 * Add banner patterns render for item * Fix item model reverse * Fix import * Add inline index * Remove hard code * Don't use PlacedBlock in special renderer * Simplify DyeColors * Allow whitespace in ItemStack string parser --------- Co-authored-by: Misode <misoloo64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no shields