1.21.9 update + blockstate equals bugfix#71
Merged
misode merged 2 commits intomisode:mainfrom Jan 2, 2026
Merged
Conversation
Contributor
Author
|
It's pretty rough but here is an attempt at the statues special renderer. For some reason mojang decided to define the textures of the statues with the .png inside the texture property but no other models are defined that way. I also don't know if this is a good approach for the various poses so feel free to discard any or all of this. Just thought I should at least try but I only got the standing pose fully working. The sitting pose is a start and the other poses are just empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added all the copper chests to the chest renderer and added the "AND" condition check to support the new shelf blocks.
I also added a small bugfix to the equals method in Blockstate because it's currently deleting properties in some specific scenarios. If you add these blocks to the structure renderer in the demo you can see what I mean:
The bug makes all the chests lose their properties because the equals method is calling .every on the empty property array of the first chest and that's always going to return true. So every chest is equals to the first and they all get their properties get flattened.
I don't have a working special renderer for the copper golem statues though. I gave it a go so I'll throw that up on another branch for reference but it's a bit of a mess and might be worth nothing.