Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes:
Everything else with the hanging sign model was fine. I don't know why it was being scaled.
I also added support for rendering shield patterns.
Pretty much the same as the banner patterns but I had to offset the patterns mesh a little bit because of z-fighting. There are also some slight transparency issues with banners+shield patterns but it's fixed by #72 .
copper-golems-statues branch
I have added the various copper golem statue poses over on this branch. They are certainly not perfect but I think they are probably good enough. But I didn't attach them to this PR just in case anyone wants some changes made. Let me know and I can toss a cleaned up version of them onto this.