Skip to content

fix(frontend): 連合が無効化されたサーバーでInstance Tickerの設定が中途半端に消えている問題を修正#17303

Merged
syuilo merged 2 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-instance-ticker-pref
Apr 11, 2026
Merged

fix(frontend): 連合が無効化されたサーバーでInstance Tickerの設定が中途半端に消えている問題を修正#17303
syuilo merged 2 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-instance-ticker-pref

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

What

Why

#17284 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review April 11, 2026 04:07
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 11, 2026
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Apr 11, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.92%. Comparing base (22577e2) to head (28e9ffa).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17303       +/-   ##
============================================
- Coverage    63.65%   14.92%   -48.74%     
============================================
  Files         1162      242      -920     
  Lines       116471    11864   -104607     
  Branches      8450     4014     -4436     
============================================
- Hits         74143     1771    -72372     
+ Misses       40124     7930    -32194     
+ Partials      2204     2163       -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 11, 2026

設定の検索には出るのに実際には存在しないということが起こりそうだけどそれは後で

@syuilo syuilo merged commit 3cb0033 into misskey-dev:develop Apr 11, 2026
22 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Apr 11, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 11, 2026

🙏🏻

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

設定の検索には出るのに実際には存在しないということが起こりそうだけどそれは後で

それは前からそう(ほかにもこれと同様の形でコンディショナルにせっていが消える箇所がいくつもある)

@kakkokari-gtyih kakkokari-gtyih deleted the fix-instance-ticker-pref branch April 11, 2026 04:17
m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Apr 12, 2026
…key-dev#17303)

* fix(frontend): 連合が無効化されたサーバーでInstance Tickerの設定が中途半端に消えている問題を修正

* Update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants