fix(backend): handle relay-delivered Announce activities correctly#17308
Open
sinoru wants to merge 2 commits intomisskey-dev:developfrom
Open
fix(backend): handle relay-delivered Announce activities correctly#17308sinoru wants to merge 2 commits intomisskey-dev:developfrom
sinoru wants to merge 2 commits intomisskey-dev:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17308 +/- ##
===========================================
- Coverage 63.67% 63.64% -0.04%
===========================================
Files 1162 1162
Lines 116490 116514 +24
Branches 8470 8454 -16
===========================================
- Hits 74175 74154 -21
- Misses 40110 40155 +45
Partials 2205 2205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
このPRによるapi.jsonの差分 |
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
Relay Announce activities now use the target note URI instead of the Announce URI for federation allowlist checks, dedup locking, and existence lookups. Notes delivered via relay are published directly to the notes stream without creating a renote. Closes misskey-dev#11056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
リレーアクター経由で届いたAnnounceアクティビティを通常のRenoteと区別し、内包された元ノートをノートストリームに直接公開するように変更しました。
Changed the handling of Announce activities from relay actors so that the inner note is published directly to the notes stream, instead of being treated as a regular Renote.
Why
リレー経由で配信されたノートはリレーアクターのAnnounceで包まれているため、既存のロジックではRenoteとして表示されてしまう問題がありました。
Notes delivered through relays are wrapped in an Announce activity by the relay actor, causing them to appear as Renotes of the original instead of standalone notes.
Fix #11056
Additional info (optional)
リレーアクターの判定は、アクターのinboxまたはsharedInboxを承認済みリレーのエントリと照合して行います。
Relay actor detection works by matching the actor's inbox or sharedInbox against accepted relay entries.
Checklist