chore(assets): unify app icon assets and generate web favicons#1
Merged
Conversation
- Replace old AppIcon.png and AppIcon.icon bundle with the new Icon Composer set - Rename source SVG inside the bundle to AppIcon.svg - Move the exported PNG to assets/AppIcon.png for README and website use - Generate favicon.ico, favicon.png, apple-touch-icon.png and app-icon.png from the master PNG - Update README to reference the new assets path - Remove stale .gitignore rule for Mist/Resources/AppIcon.png
There was a problem hiding this comment.
Pull request overview
This PR standardizes Mist’s icon source-of-truth by updating the Icon Composer bundle to use a single, consistently named SVG (AppIcon.svg), updating the README to reference the exported PNG under assets/, and cleaning up ignore rules so icon assets can be tracked.
Changes:
- Update
README.mdto load the app icon from./assets/AppIcon.png. - Simplify
AppIcon.iconmetadata to reference a single vector sourceAppIcon.svgand set fill to automatic. - Remove the stale
.gitignorerule that ignoredMist/Resources/AppIcon.png.
Reviewed changes
Copilot reviewed 2 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Points README icon image to assets/AppIcon.png instead of the removed root asset. |
| Mist/Resources/AppIcon.icon/icon.json | Updates Icon Composer metadata to use AppIcon.svg as the layer source and adjusts fill behavior. |
| Mist/Resources/AppIcon.icon/Assets/AppIcon.svg | Adds the renamed/standardized SVG vector source for the app icon bundle. |
| .gitignore | Stops ignoring the previously-stale Mist/Resources/AppIcon.png path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppIcon.pngand legacyAppIcon.iconbundle with the new Icon Composer set.AppIcon.svgso it is the single vector source.assets/AppIcon.pngand use it from the README.favicon.ico,favicon.png,apple-touch-icon.png,app-icon.png) from the master PNG..gitignorerule that ignoredMist/Resources/AppIcon.png.Test plan
assets/AppIcon.png.Mist/Resources/AppIcon.iconin Icon Composer to confirm the SVG loads correctly.AppIconis compiled into the app bundle.mist.wsand verify favicon/app-icon links.