Lint with ruff, pyright and mypy the examples and extra folders#226
Merged
Lint with ruff, pyright and mypy the examples and extra folders#226
ruff, pyright and mypy the examples and extra folders#226Conversation
GaspardBT
approved these changes
May 26, 2025
jean-malo
reviewed
May 26, 2025
Contributor
jean-malo
left a comment
There was a problem hiding this comment.
@amenasria why not a makefile and / or uv scripts like in our other repos?
Contributor
Author
|
@jean-malo I want to avoid using both uv and poetry, we'll move those when we'll move to uv. For Makefile idk it would be weird to have that here. |
Contributor
Author
|
For now we've been droppping bash files, so I'm keeping the bash files going. |
jean-malo
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
ruff,pyrightandmypyon commit modifications.ruff,pyrightandmypyon all files in the folders. It does not run on the examples folder yetThe folders we're linting are:
examples/src/mistralai_private/extra/src/mistralai_private/_hooks/