fix: align pyproject.toml version directly in generation workflows#392
Merged
louis-sanna-dev merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Instead of using a separate workflow with workflow_run trigger (which runs on the wrong branch), embed the version alignment logic directly in each SDK generation workflow as a job that runs after generation. This approach works because: - Same workflow = same GITHUB_TOKEN permissions - needs: generate ensures it runs after PR is created - No trigger gymnastics or branch detection issues Deletes the standalone align_pyproject_version.yaml workflow.
andreaonofrei01
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embeds the version alignment logic directly in each SDK generation workflow instead of using a separate
workflow_runtrigger.Why the previous approaches failed:
pull_requesttrigger:GITHUB_TOKENactions don't trigger PR workflows (security measure)workflow_runtrigger: Runs on the triggering workflow's branch (main), not the PR branchThis approach works because:
GITHUB_TOKENpermissionsneeds: generateensures it runs after the PR is createdChanges
align-versionjob to all 3 SDK generation workflowsalign_pyproject_version.yamlworkflowTest plan
align-versionjob runs after generation and updates pyproject.toml in the PR