docs(migration): fix async streaming example with complete runnable code#398
Open
abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
Open
docs(migration): fix async streaming example with complete runnable code#398abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
Conversation
Both async examples (v0.x and v1.x) were missing the async def main() wrapper and asyncio.run() call, making them non-functional as standalone scripts. Added import asyncio, async def main() wrapper, asyncio.run() entry point, and a note about environments with active event loops. Fixes mistralai#294
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The async streaming example in MIGRATION.md is missing the
async def main()wrapper andasyncio.run()call, making it non-functional as a standalone script.Users in environments with an already-running event loop (Jupyter, Positron, VS Code interactive) get
RuntimeError: asyncio.run() cannot be called from a running event loop.Changes
async def main()andasyncio.run()Fixes #294