Skip to content

Fixes errors and other updates#3

Open
seakintruth wants to merge 23 commits into
mitchelljy:masterfrom
seakintruth:master
Open

Fixes errors and other updates#3
seakintruth wants to merge 23 commits into
mitchelljy:masterfrom
seakintruth:master

Conversation

@seakintruth

Copy link
Copy Markdown
  • Fixed request headers
  • Fix for multi-platform paths and error handling
  • Formatting
  • Fixed extension guessing
  • Added faker to README.md requirements
  • re-ordered code_chars to match sequence of prnt.sc
  • updates help to acknowledge 6 or 7 characters allowed for --start_code

@seakintruth

Copy link
Copy Markdown
Author

Adds several arguments to aid in continuing scrape

@emezelenme

Copy link
Copy Markdown

Hey. Help,

Starting with directory file count of 0
403 Client Error: Forbidden for url: https://image.prntscr.com/image/s3OPIhTBRj6-hqUHVdwJRw.jpg with image
:

@RPINerd RPINerd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these updates!
For the --resume_from_last argument, personally I would just call it resume, but that's more personal preference. You could also use action='store_true' so that you wouldn't need to specify True or False

@remagorp

Copy link
Copy Markdown

Add proxies, they'll ban you very fast.

@bikkesbakker

Copy link
Copy Markdown

Not working, says images saved but there are no images in the folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants