Skip to content

Enhance FormulaFilter to gracefully handle nulls #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchspano merged 1 commit into from
Jul 18, 2025
Merged

Enhance FormulaFilter to gracefully handle nulls #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trigger-actions-framework/main/default/classes/FormulaFilter.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ global class FormulaFilter {
);
toProcess.newSobject = record;
toProcess.oldSobject = recordPrior;
if ((Boolean) fx.evaluate(toProcess)) {
if ((Boolean) fx.evaluate(toProcess) == true) {
result.triggerNew.add(record);
result.triggerOld.add(recordPrior);
}
Expand Down
29 changes: 28 additions & 1 deletion trigger-actions-framework/main/default/classes/FormulaFilterTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
@SuppressWarnings(
'PMD.ApexUnitTestClassShouldHaveRunAs, PMD.AvoidGlobalModifier'
)
@IsTest
@IsTest(IsParallel=true)
global class FormulaFilterTest {
private static final String ACCOUNT_SOBJECT_NAME = 'Account';
private static final String EXCEPTION_SHOULD_BE_THROWN = 'An exception should be thrown';
Expand Down Expand Up @@ -327,6 +327,33 @@ global class FormulaFilterTest {
);
}

@IsTest
private static void formulaEvaluatingToNullShouldBeTreatedAsFalse() {
triggerNew[1].Description = 'example 1';
configuration.Entry_Criteria__c = 'CONTAINS(record.Description, "example")';
FormulaFilter filter = new FormulaFilter(
configuration,
TriggerOperation.BEFORE_UPDATE,
ACCOUNT_SOBJECT_NAME
);

FormulaFilter.Result result = filter.filterByEntryCriteria(
triggerNew,
triggerOld
);

System.Assert.areEqual(
1,
result.triggerNew.size(),
'Only 1 record should be processed when CONTAINS evaluates to null for the first record'
);
System.Assert.areEqual(
1,
result.triggerOld.size(),
'Only 1 record should be processed when CONTAINS evaluates to null for the first record'
);
}

@SuppressWarnings('PMD.ApexDoc')
global class AccountTriggerRecord extends TriggerRecord {
global Account record {
Expand Down
2 changes: 1 addition & 1 deletion trigger-actions-framework/main/default/classes/TriggerActionFlowAddErrorTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

@SuppressWarnings('PMD.ApexDoc, PMD.ApexUnitTestClassShouldHaveRunAs')
@IsTest
@IsTest(IsParallel=true)
private class TriggerActionFlowAddErrorTest {
private static final String MY_STRING = 'MY_STRING';
private static final String NAME = 'Name';
Expand Down
2 changes: 1 addition & 1 deletion trigger-actions-framework/main/default/classes/TriggerActionFlowClearBypassTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

@SuppressWarnings('PMD.ApexDoc, PMD.ApexUnitTestClassShouldHaveRunAs')
@IsTest
@IsTest(IsParallel=true)
private class TriggerActionFlowClearBypassTest {
private static final String MY_STRING = 'MY_STRING';
private static List<TriggerActionFlowClearBypass.Request> requests = new List<TriggerActionFlowClearBypass.Request>();
Expand Down
2 changes: 1 addition & 1 deletion trigger-actions-framework/main/default/classes/TriggerActionFlowIsBypassedTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

@SuppressWarnings('PMD.ApexDoc, PMD.ApexUnitTestClassShouldHaveRunAs')
@IsTest
@IsTest(IsParallel=true)
private class TriggerActionFlowIsBypassedTest {
private static final String MY_STRING = 'MY_STRING';
private static List<TriggerActionFlowIsBypassed.Request> requests = new List<TriggerActionFlowIsBypassed.Request>();
Expand Down
Loading