chore: Use our edx-submissions fork to fix the xqueue grade scaling bug#131
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a forked edx-submissions override to address xqueue grade scaling.
Changes:
- Adds the override to applicable MITx cells.
- Removes existing
celery-redbeatandopenedx-forumpins.
Comments suppressed due to low confidence (9)
deployments/mit-ol/build_manifest.yaml:103
- This is a GitHub web
treeURL, not a Git clone URL.uv pip install -rwill attempt to clone that nonexistent repository path, so the master/mitx build cannot install this override. Use pip's VCS ref syntax.
- git+https://github.com/mitodl/edx-submissions/tree/fix/xqueue-scale-points-earned#egg=edx-submissions
deployments/mit-ol/build_manifest.yaml:137
- This is a GitHub web
treeURL, not a Git clone URL.uv pip install -rwill attempt to clone that nonexistent repository path, so the master/mitx-staging build cannot install this override. Use pip's VCS ref syntax.
- git+https://github.com/mitodl/edx-submissions/tree/fix/xqueue-scale-points-earned#egg=edx-submissions
deployments/mit-ol/build_manifest.yaml:237
- This is a GitHub web
treeURL, not a Git clone URL.uv pip install -rwill attempt to clone that nonexistent repository path, so the verawood/mitx-staging build cannot install this override. Use pip's VCS ref syntax.
- git+https://github.com/mitodl/edx-submissions/tree/fix/xqueue-scale-points-earned#egg=edx-submissions
deployments/mit-ol/build_manifest.yaml:77
- This PR is scoped to an edx-submissions override, but this hunk also removes
celery-redbeatfrom master/mitx. It is not present in edx-platform's base requirements, so rebuilding this cell will drop the Redis-backed Celery scheduler dependency. Restore the existing package unless that scheduler removal is an explicitly tested part of this change.
packages:
deployments/mit-ol/build_manifest.yaml:111
- This PR is scoped to an edx-submissions override, but this hunk also removes
celery-redbeatfrom master/mitx-staging. It is not present in edx-platform's base requirements, so rebuilding this cell will drop the Redis-backed Celery scheduler dependency. Restore the existing package unless that scheduler removal is an explicitly tested part of this change.
packages:
deployments/mit-ol/build_manifest.yaml:145
- This PR is scoped to an edx-submissions override, but this hunk also removes
celery-redbeatfrom ulmo/xpro. It is not present in edx-platform's base requirements, so rebuilding this cell will drop the Redis-backed Celery scheduler dependency. Restore the existing package unless that scheduler removal is an explicitly tested part of this change.
packages:
deployments/mit-ol/build_manifest.yaml:177
- This PR is scoped to an edx-submissions override, but this hunk also removes
celery-redbeatfrom verawood/mitx. It is not present in edx-platform's base requirements, so rebuilding this cell will drop the Redis-backed Celery scheduler dependency. Restore the existing package unless that scheduler removal is an explicitly tested part of this change.
packages:
deployments/mit-ol/build_manifest.yaml:212
- This PR is scoped to an edx-submissions override, but this hunk also removes
celery-redbeatfrom verawood/mitx-staging. It is not present in edx-platform's base requirements, so rebuilding this cell will drop the Redis-backed Celery scheduler dependency. Restore the existing package unless that scheduler removal is an explicitly tested part of this change.
packages:
deployments/mit-ol/build_manifest.yaml:246
- This PR is scoped to an edx-submissions override, but this hunk also removes
celery-redbeatfrom verawood/xpro. It is not present in edx-platform's base requirements, so rebuilding this cell will drop the Redis-backed Celery scheduler dependency. Restore the existing package unless that scheduler removal is an explicitly tested part of this change.
packages:
…beat overrides Copilot flagged the GitHub tree URL used for the edx-submissions fork as an invalid pip VCS ref (uv pip would try to clone that literal path), so switch it to proper git ref syntax. It also flagged the removal of celery-redbeat and openedx-forum==0.4.3 as unrelated to this change, but both removals are intentional: celery-redbeat is no longer used anywhere in this deployment group, and verawood's base edx-platform already pins the correct openedx-forum version, so the override is redundant there (dropped from both verawood/mitx and verawood/xpro). Also add the DISABLE_LIBRARY_CREATION field to the committed cms aqueduct settings model to clear pre-existing drift against edx-platform master (unrelated to this change, but caught by the settings-verify gate on this PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
Uses our fork of edx-submissions so that we can patch the xqueue grade scaling bug that is blocking student code submissions
How can this be tested?
Once deployed, verify that xqueue-watcher responses stop erroring due to float values being returned
Additional Context
openedx/edx-submissions#366