Delete micromasters resources and remove ETLSource constant - #3670
Merged
Conversation
OpenAPI Changes8 changes: 7 error, 0 warning, 1 info Unexpected changes? Ensure your branch is up-to-date with |
Contributor
There was a problem hiding this comment.
Pull request overview
Cleanup follow-up to the prior removal of the MicroMasters ETL by removing remaining database rows and eliminating the now-unused ETLSource.micromasters enum member so the codebase no longer exposes or depends on that source.
Changes:
- Add a data migration (
0118) to delete allLearningResourcerows withetl_source="micromasters". - Update historical migration
0052to use the"micromasters"string literal (removing dependency onETLSource.micromasters). - Remove
micromastersfrom theETLSourceenum.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| learning_resources/migrations/0118_delete_micromasters_resources.py | Deletes remaining DB rows for etl_source="micromasters" after the prior unpublish/deindex migration. |
| learning_resources/migrations/0052_learningresource_certification_type.py | Removes the migration’s dependency on ETLSource.micromasters by using a string literal. |
| learning_resources/etl/constants.py | Removes the ETLSource.micromasters enum member. |
Comment on lines
80
to
85
| class ETLSource(ExtendedEnum): | ||
| """Enum of ETL sources""" | ||
|
|
||
| micromasters = "micromasters" | ||
| mit_edx = "mit_edx" | ||
| mitpe = "mitpe" | ||
| mitxonline = "mitxonline" |
mbertrand
force-pushed
the
mb/delete-micromasters-resources
branch
from
July 24, 2026 20:17
e5354c0 to
b05c9ff
Compare
mbertrand
added
Needs Review
shanbady
requested changes
Jul 27, 2026
shanbady
left a comment
shanbady
left a comment
Contributor
There was a problem hiding this comment.
change looks good just needs an update to the openapi spec
shanbady
added
Waiting on author
and removed
Needs Review
mbertrand
force-pushed
the
mb/delete-micromasters-resources
branch
from
July 27, 2026 15:09
b05c9ff to
3ebe46d
Compare
Member
Author
|
openapi spec is up to date, errors are due to this being considered a breaking change ( "micromasters" is no longer a valid value for the |
mbertrand
added
Needs Review
shanbady
added
Waiting on author
and removed
Needs Review
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mbertrand
force-pushed
the
mb/delete-micromasters-resources
branch
from
July 27, 2026 19:46
3ebe46d to
4856d0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A — follow-up to #3663
Description (What does it do?)
Follow-up cleanup to #3663, which removed the micromasters ETL pipeline and unpublished/deindexed all remaining
etl_source=micromastersresources from OpenSearch and Qdrant.LearningResourcerows withetl_source="micromasters"via a new data migration (0118). No deindexing is needed — the resources were already removed from OpenSearch/Qdrant by the0117migration in Remove micromasters ETL #3663; related runs, content files, and relationship rows are removed by FK cascades.ETLSource.micromastersconstant.0052to use the"micromasters"string literal instead ofETLSource.micromasters.name, so historical migrations no longer depend on the removed enum member.How can this be tested?
docker compose run --rm web python manage.py migrate learning_resources—0118should apply cleanly and delete any remaining micromasters resources.docker compose run --rm web python manage.py makemigrations --check --dry-run— no model changes detected (etl_sourceis a plain CharField, so removing the enum member causes no schema drift).LearningResource.objects.filter(etl_source="micromasters").count()should be 0 after migrating.