-
Notifications
You must be signed in to change notification settings - Fork 76
feat(release-tracks): membership tab on object page #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avwchapman
wants to merge
4
commits into
beta
Choose a base branch
from
781-release-track-membership-object
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,834
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
af8d2e2
feat: add release track membership view to STIX objects
avwchapman 2d6c268
Merge branch 'beta' into 781-release-track-membership-object
avwchapman cdb73e3
fix: refine release track membership statuses and releases
avwchapman 39e6478
fix: show release track status transition dates
avwchapman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
180 changes: 180 additions & 0 deletions
180
src/app/components/stix/stix-page-tabs/membership-section/membership-section.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,180 @@ | ||
| <section class="membership-section"> | ||
| <header class="membership-header"> | ||
| <h2>Release Track Distribution</h2> | ||
|
|
||
| <div class="membership-header-actions"> | ||
| <button | ||
| type="button" | ||
| class="membership-action-button" | ||
| [disabled]="!hasSelection" | ||
| (click)="clearSelection()"> | ||
| Clear | ||
| </button> | ||
|
|
||
| <button | ||
| type="button" | ||
| class="membership-action-button membership-action-button--primary" | ||
| [disabled]="selectedReleaseCount !== 2" | ||
| (click)="compareSelectedReleases()"> | ||
| Compare ({{ selectedReleaseCount }}/2) | ||
| </button> | ||
| </div> | ||
| </header> | ||
|
|
||
| <div *ngIf="loading" class="loading-state"> | ||
| Loading release track membership... | ||
| </div> | ||
|
|
||
| <div *ngIf="!loading" class="release-track-list"> | ||
| <article | ||
| *ngFor="let membership of memberships; trackBy: trackByMembership" | ||
| class="release-track-card"> | ||
| <header class="release-track-header"> | ||
| <div class="release-track-heading"> | ||
| <h3>{{ getTrackName(membership) }}</h3> | ||
| <p>{{ getTrackDescription(membership) }}</p> | ||
| </div> | ||
|
|
||
| <div class="release-track-actions"> | ||
| <button | ||
| *ngIf="canViewReleaseTrackDashboard" | ||
| type="button" | ||
| class="view-track-button" | ||
| [disabled]="!hasSelectedReleaseForTrack(membership)" | ||
| (click)="viewTrack(membership, $event)"> | ||
| View Track | ||
|
|
||
| <span class="external-link-icon" aria-hidden="true"> ↗ </span> | ||
| </button> | ||
|
|
||
| <span | ||
| class="track-type-badge" | ||
| [class.track-type-badge--virtual]="isVirtualTrack(membership)"> | ||
| {{ getTrackType(membership) }} | ||
| </span> | ||
| </div> | ||
| </header> | ||
|
|
||
| <div class="release-track-content"> | ||
| <section class="draft-column"> | ||
| <h4>Current Draft Status</h4> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| <p *ngIf="!hasCurrentDraft(membership)" class="no-current-draft"> | ||
| Not in current draft. | ||
| </p> | ||
|
|
||
| <div | ||
| *ngIf="hasCurrentDraft(membership)" | ||
| class="draft-card" | ||
| (click)="$event.stopPropagation()"> | ||
| <label class="release-selection"> | ||
| <input | ||
| type="checkbox" | ||
| [checked]=" | ||
| isReleaseSelected(getCurrentDraft(membership), membership) | ||
| " | ||
| [disabled]=" | ||
| !isReleaseSelected(getCurrentDraft(membership), membership) && | ||
| selectedReleaseCount >= 2 | ||
| " | ||
| (click)="$event.stopPropagation()" | ||
| (change)=" | ||
| toggleReleaseSelection( | ||
| getCurrentDraft(membership), | ||
| membership, | ||
| $any($event.target).checked | ||
| ) | ||
| " /> | ||
|
|
||
| <span class="release-information"> | ||
| <strong | ||
| class="draft-status" | ||
| [class.draft-status--in-review]="isDraftInReview(membership)" | ||
| [class.draft-status--staged]="isDraftStaged(membership)"> | ||
| {{ getDraftStatusLabel(membership) }} | ||
| </strong> | ||
|
|
||
| <small> | ||
| {{ getDraftDateLabel(membership) }} | ||
| </small> | ||
| </span> | ||
| </label> | ||
|
|
||
| <div class="status-progress"> | ||
| <span | ||
| class="status-step" | ||
| [class.status-step--active]=" | ||
| isDraftStepActive(membership, 'work-in-progress') | ||
| "> | ||
| WIP | ||
| </span> | ||
|
|
||
| <span | ||
| class="status-step" | ||
| [class.status-step--review-active]="isDraftInReview(membership)" | ||
| [class.status-step--active]=" | ||
| isDraftStepActive(membership, 'review') | ||
| "> | ||
| Review | ||
| </span> | ||
|
|
||
| <span | ||
| class="status-step" | ||
| [class.status-step--staged-active]="isDraftStaged(membership)" | ||
| [class.status-step--active]=" | ||
| isDraftStepActive(membership, 'staged') | ||
| "> | ||
| Staged | ||
| </span> | ||
| </div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <section class="releases-column"> | ||
| <h4>Production Releases</h4> | ||
|
|
||
| <p | ||
| *ngIf="getProductionReleases(membership).length === 0" | ||
| class="no-production-releases"> | ||
| No production releases found. | ||
| </p> | ||
|
|
||
| <div | ||
| *ngIf="getProductionReleases(membership).length > 0" | ||
| class="production-release-list" | ||
| (click)="$event.stopPropagation()"> | ||
| <label | ||
| *ngFor=" | ||
| let release of getProductionReleases(membership); | ||
| trackBy: trackByRelease | ||
| " | ||
| class="production-release"> | ||
| <input | ||
| type="checkbox" | ||
| [checked]="isReleaseSelected(release, membership)" | ||
| [disabled]=" | ||
| !isReleaseSelected(release, membership) && | ||
| selectedReleaseCount >= 2 | ||
| " | ||
| (click)="$event.stopPropagation()" | ||
| (change)=" | ||
| toggleReleaseSelection( | ||
| release, | ||
| membership, | ||
| $any($event.target).checked | ||
| ) | ||
| " /> | ||
|
|
||
| <span class="release-tag-icon" aria-hidden="true"></span> | ||
|
|
||
| <span class="release-information"> | ||
| <strong>{{ getReleaseVersion(release) }}</strong> | ||
| <small>{{ getReleaseDateLabel(release) }}</small> | ||
| </span> | ||
| </label> | ||
| </div> | ||
| </section> | ||
| </div> | ||
| </article> | ||
| </div> | ||
| </section> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth adding a way to add an object to a track from this interface, so users can manage that without leaving the page. If the object isn’t currently in any tracks, we could show an empty state here with something like “This object is not in any tracks yet” and an action to add it to a release track