Integrate bitflow cache planning and writeback#30
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc62b8ab8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for artifact_name in managed_embedded_report_artifacts { | ||
| ignore( | ||
| remove_tree(join_path(store_root, run_store_sanitize_id(artifact_name))), |
There was a problem hiding this comment.
This loop unconditionally deletes playwright-report and vitest-report from the shared artifact store on every run, before checking whether those directories were created by the embedded-report feature. If a workflow uses actions/upload-artifact with either of these common names, those uploaded files are removed during persist_run_record, so the run loses/corrupts real artifacts even when no embedded JSON report is present. The cleanup should be scoped to files generated by this feature (or moved to a separate namespace) instead of deleting the whole artifact name directory.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation