[PoC] Support non js identifier token #322
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS Modules Kit currently does not allow tokens with names that are invalid as JS identifiers. However, it may allow them in the future, but only when `cmkOptions.namedExport` is set to `false`. We will refactor to ensure tests do not break when this change is implemented.
…`namedExport` is false
|
mizdra
force-pushed
the
support-non-js-ident-token
branch
from
a1ebb44 to
3d6af46
Compare
mizdra
commented
Jan 28, 2026
| for (const token of cssModule.localTokens) { | ||
| // Reject special names as they may break .d.ts files | ||
| if (!isValidAsJSIdentifier(token.name)) { | ||
| if (config.namedExports && !isValidAsJSIdentifier(token.name)) { |
Owner
Author
There was a problem hiding this comment.
It is probably not advisable to permit all characters allowed in CSS class names. foo\' and bar\\ are good examples. Both will break .d.ts files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is still incomplete.