Refactoring tests and token name validation #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS Modules Kit currently does not allow tokens with names that are invalid as JS identifiers. However, it may allow them in the future, but only when `cmkOptions.namedExport` is set to `false`. We will refactor to ensure tests do not break when this change is implemented.
|
Extract duplicated token name validation logic from checker.ts and dts-generator.ts into a shared `validateTokenName` function in util.ts. This consolidates the validation rules for invalid JS identifiers, `__proto__`, and `default` (when namedExports is enabled) into one place. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the code in preparation for resolving #323.