Open
Conversation
- Switch from Buffered to Framed transports - Connect to a keyspace on connection; remove keyspace argument to other calls - Make saveColumnPath use a columnParent rather than a columnPath Also fix some mild documentation issues Tested that SuperColumnFamilies are saveable using new code Todo: - Make sure regular CFs can be saved - Update unit tests - Backwards compatibility to 0.6? - Remove debugging cruft
Owner
|
That's the right method, thanks very much I'll merge a little later tonight :) |
Author
|
Great, let me know how it goes/went. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's still a bit hacky, and doesn't expose any of the new 0.7 features, so this probably should stay on a branch until one of us spends some more time one it. But batch_mutate works, which is the main thing.
Not sure about Github's pull requests: I can't tell if this pull request is asking you to put it into master or just make a copy of my branch.