Skip to content

Show recently typed paths in save/download path dialog#76

Merged
mkbula merged 13 commits into
mkbula:masterfrom
himsin:pathHistory
May 14, 2026
Merged

Show recently typed paths in save/download path dialog#76
mkbula merged 13 commits into
mkbula:masterfrom
himsin:pathHistory

Conversation

@himsin
Copy link
Copy Markdown
Contributor

@himsin himsin commented Apr 23, 2026

No description provided.

@himsin himsin closed this Apr 23, 2026
@himsin himsin reopened this Apr 23, 2026
@mkbula
Copy link
Copy Markdown
Owner

mkbula commented Apr 26, 2026

@himsin I changed UI for the change save/download path, can u please rebase and resolve conflicts?

@himsin
Copy link
Copy Markdown
Contributor Author

himsin commented Apr 27, 2026

@Maciejonos Resolved the conflicts Please review now.

@mkbula
Copy link
Copy Markdown
Owner

mkbula commented May 13, 2026

Looks good overall, one note:

  • Almost every call site (ContextMenu, TorrentDetailsPanel, SearchPanel desktop+mobile) calls addPath before the mutation runs. If qBittorrent rejects the path, the typo stays in suggestions forever. Maybe move it on success only callback? AddTorrentModal already does it correctly if u wanna take a look.

@himsin
Copy link
Copy Markdown
Contributor Author

himsin commented May 13, 2026

@mkbula Done, all addPath calls now only execute on success:

@mkbula mkbula merged commit fa6024d into mkbula:master May 14, 2026
2 checks passed
@himsin himsin deleted the pathHistory branch May 14, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants